fix: make MenuAccessControl availalble in mocking environment #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on internal CI against 24.5, 24.6 and 24.7 |
tepi
reviewed
Jan 14, 2025
Comment on lines
96
to
97
| // Workaround to support both Vaadin 24.4 that does not have | ||
| // SpringMenuAccessControl |
There was a problem hiding this comment.
Maybe something is missing in this comment, did it mean to mention another vaadin version as well?
There was a problem hiding this comment.
You're right, the comment is incomplete.
SpringMenuAccessControl has been introduced in Vaadin 24.5, but Testbench main is currently 24.4+
tepi
approved these changes
Jan 14, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1844