Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: handle type not found in pretty print #1849

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

mcollovati
Copy link
Contributor

@mcollovati mcollovati commented Jan 16, 2025

Vaadin 24.7 introduces helper methods for Spring Data integration. This caused an issue with PrettyPrinter introspection when UI Unit test is used in non Spring projects.
This change adds a safe fallback for members introspection if kotlin inspector fails.

Copy link
Contributor

@mshabarov mshabarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, however, I suggest to add two minor things:

  1. A comment that explains the reason for TypeNotPresentException
  2. give meaningful var names to f and m.

@mcollovati mcollovati requested a review from mshabarov January 16, 2025 08:58
@mshabarov mshabarov enabled auto-merge (squash) January 16, 2025 08:59
Vaadin 24.7 introduces helper methods for Spring Data integration.
This caused an issue with PrettyPrinter introspection when UI Unit test
is used in non Spring projects.
This change adds a safe fallback for memebers introspection, if kotlin
inspector fails.
@mcollovati mcollovati force-pushed the fix/prettyprint-grid-with-pageable branch from ccc50bf to de4e4fc Compare January 16, 2025 09:44
@mcollovati mcollovati force-pushed the fix/prettyprint-grid-with-pageable branch from de4e4fc to 6354abc Compare January 16, 2025 10:00
@mshabarov mshabarov merged commit cc01ffd into main Jan 16, 2025
2 checks passed
@mshabarov mshabarov deleted the fix/prettyprint-grid-with-pageable branch January 16, 2025 10:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants