Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Commit

Permalink
Bump Web Component version to 5.6.10 (#1126)
Browse files Browse the repository at this point in the history
  • Loading branch information
tomivirkki authored Sep 25, 2020
1 parent f3b0a25 commit f7f6b54
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public void toStringIsUsedForObjectSerialization() {

GridElement grid = $(GridElement.class).first();

TestBenchElement scroller = grid.$("vaadin-grid-outer-scroller")
.id("outerscroller");
TestBenchElement scroller = grid.$("table").id("table");

// Scroll value that scrolls a bit further than the 100000th row to
// trigger the loading loop issue (vaadin-grid-flow issue #578)
Expand Down
2 changes: 1 addition & 1 deletion vaadin-grid-flow/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<dependency>
<groupId>org.webjars.bowergithub.vaadin</groupId>
<artifactId>vaadin-grid</artifactId>
<version>5.6.7</version>
<version>5.6.10</version>
</dependency>
<dependency>
<groupId>org.webjars.bowergithub.polymerelements</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
*
*/
@Tag("vaadin-grid")
@NpmPackage(value = "@vaadin/vaadin-grid", version = "5.6.7")
@NpmPackage(value = "@vaadin/vaadin-grid", version = "5.6.10")
@JsModule("@vaadin/vaadin-grid/src/vaadin-grid.js")
@JsModule("@vaadin/vaadin-grid/src/vaadin-grid-column.js")
@JsModule("@vaadin/vaadin-grid/src/vaadin-grid-sorter.js")
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -918,9 +918,7 @@

// TODO: should be removed once https://github.com/vaadin/vaadin-grid/issues/1471 gets implemented
grid.$connector.setVerticalScrollingEnabled = tryCatchWrapper(function(enabled) {
// There are two scollable containers in grid so apply the changes for both
setVerticalScrollingEnabled(grid.$.table, enabled);
setVerticalScrollingEnabled(grid.$.outerscroller, enabled);

// Since the scrollbars were toggled, there might have been some changes to layout
// size. Notify grid of the resize to ensure everything is in place.
Expand Down

0 comments on commit f7f6b54

Please # to comment.