Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Connector cleanup #1108

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Connector cleanup #1108

merged 1 commit into from
Sep 3, 2020

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Sep 3, 2020 •
edited
Loading

...for example, the internal flag ensureSubCacheDelay is fixed to true, and I don't see why this constant would be changed anytime soon in the future, so it's pointless to have logic in the connector that only applied if the flag was false.

DiegoCardoso
DiegoCardoso approved these changes Sep 3, 2020
View reviewed changes
Copy link

@DiegoCardoso DiegoCardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomivirkki tomivirkki merged commit e07fe74 into master Sep 3, 2020
@tomivirkki tomivirkki deleted the connector-cleanup branch September 3, 2020 18:07
tomivirkki added a commit that referenced this pull request Sep 24, 2020
@tomivirkki
Connector cleanup (#1108)
abdce7e
@tomivirkki tomivirkki mentioned this pull request Sep 24, 2020
Merged
tomivirkki added a commit that referenced this pull request Sep 25, 2020
@tomivirkki @TatuLund
Cherry-pick #1084, #1108, #1116, #1102 (#1123)
8ea9ae9 
* Perf/unnecessary page calls (#1084)

* Connector cleanup (#1108)

* fix: check for connector before using it (#1116)

* fix: prevent possible memory leak (#1102)

* Use generic findElement to avoid adding a dependency

Co-authored-by: Tatu Lund <tatu@vaadin.com>
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomivirkki @DiegoCardoso