Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

Update version in @NpmPackage #1120

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Update version in @NpmPackage #1120

merged 1 commit into from
Sep 21, 2020

Conversation

ZheSun88
Copy link
Contributor

No description provided.

@vaadin-bot
Copy link

SonarQube analysis reported 32 issues

  • CRITICAL 2 critical
  • MAJOR 8 major
  • MINOR 19 minor
  • INFO 3 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L2357: Remove usage of generic wildcard type. rule
  2. CRITICAL Grid.java#L3109: Define a constant instead of duplicating this literal "direction" 4 times. rule
  3. MAJOR Grid.java#: This file has 1,755 lines, which is greater than 750 authorized. Split it into smaller files. rule
  4. MAJOR Grid.java#L1893: Call "Optional#isPresent()" before accessing the value. rule
  5. MAJOR Grid.java#L1894: Either log or rethrow this exception. rule
  6. MAJOR Grid.java#L1913: Either log or rethrow this exception. rule
  7. MAJOR Grid.java#L2922: Call "Optional#isPresent()" before accessing the value. rule
  8. MAJOR Grid.java#L2932: Call "Optional#isPresent()" before accessing the value. rule
  9. MAJOR Grid.java#L3619: Rename "editor" which hides the field declared at line 1163. rule
  10. MAJOR Grid.java#L4030: Remove this unused method parameter "event". rule

@DiegoCardoso DiegoCardoso merged commit 3e466a4 into master Sep 21, 2020
@DiegoCardoso DiegoCardoso deleted the ZheSun88-patch-1 branch September 21, 2020 07:28
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants