Skip to content
This repository has been archived by the owner on Dec 12, 2022. It is now read-only.

fix: prevent possible memory leak (#1102) #1124

Merged
merged 1 commit into from
Sep 25, 2020
Merged

fix: prevent possible memory leak (#1102) #1124

merged 1 commit into from
Sep 25, 2020

Conversation

DiegoCardoso
Copy link

CP from #1102

Prevent possible memory leak when e.g. Grid is removed from layout as data provider listener is not explicitly removed.
@vaadin-bot
Copy link

SonarQube analysis reported 27 issues

  • CRITICAL 2 critical
  • MAJOR 8 major
  • MINOR 16 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL Grid.java#L2328: Remove usage of generic wildcard type. rule
  2. CRITICAL Grid.java#L2972: Define a constant instead of duplicating this literal "direction" 4 times. rule
  3. MAJOR Grid.java#: This file has 1,706 lines, which is greater than 750 authorized. Split it into smaller files. rule
  4. MAJOR Grid.java#L1887: Call "Optional#isPresent()" before accessing the value. rule
  5. MAJOR Grid.java#L1888: Either log or rethrow this exception. rule
  6. MAJOR Grid.java#L1907: Either log or rethrow this exception. rule
  7. MAJOR Grid.java#L2785: Call "Optional#isPresent()" before accessing the value. rule
  8. MAJOR Grid.java#L2795: Call "Optional#isPresent()" before accessing the value. rule
  9. MAJOR Grid.java#L3498: Rename "editor" which hides the field declared at line 1157. rule
  10. MAJOR Grid.java#L3908: Remove this unused method parameter "event". rule

@DiegoCardoso DiegoCardoso merged commit f3b0a25 into 4.2 Sep 25, 2020
@DiegoCardoso DiegoCardoso deleted the cp/1102-4.2 branch September 25, 2020 09:00
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants