This repository has been archived by the owner on Dec 12, 2022. It is now read-only.
fix: make connector patch ItemCache only once (#1128) #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
approved these changes
Oct 2, 2020
Previous fix for client and server grids on the same page was to store the original `ensureSubCacheForScaledIndex` method before it was patched by connector, but that introduced a stack overflow error after a second grid is added from the server. This fix makes ItemCache patching to happen only once the first server grid is added, and prevents it from happening after other grids are added. Fixes #1077
DiegoCardoso
force-pushed
the
cp/1128-4.2
branch
from
9cd58c7 to
f2eb347
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CP from #1128