fix: workaround a Safari sticky positioning issue with disappearing h…

…eader (#1799)
vaadin · Sep 25, 2020 · 08f0f44 · 08f0f44
1 parent 299482f
commit 08f0f44
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 0 deletions.
diff --git a/src/vaadin-grid-scroll-mixin.html b/src/vaadin-grid-scroll-mixin.html
@@ -301,6 +301,14 @@
           body.insertBefore(items[i], items[0]);
         }
       }
+
+      // Due to a rendering bug, reordering the rows can make the sticky header disappear on Safari
+      // if the grid is used inside of a flex box. This is a workaround for the issue.
+      if (this._safari) {
+        const {transform} = this.$.header.style;
+        this.$.header.style.transform = '';
+        setTimeout(() => this.$.header.style.transform = transform);
+      }
     }
 
     _frozenCellsChanged() {

diff --git a/src/vaadin-grid.html b/src/vaadin-grid.html
@@ -733,6 +733,18 @@
             this.$.items.style.paddingBottom = `${this.$.footer.offsetHeight}px`;
           }
         }
+
+        if (this._ios) {
+          const isOldIOS = !window.CSS.supports('position', 'sticky');
+          if (isOldIOS) {
+            // Due to a rendering bug, the sticky header may disappear on an older iOS (10-12) Safari
+            // if the grid is used inside of a flex box. This is a workaround for the issue.
+            this.$.table.style.height = '';
+            this.$.table.style.minHeight = '100%';
+            this.$.table.style.maxHeight = '100%';
+            setTimeout(() => this.$.table.style.height = `${this.$.scroller.offsetHeight}px`);
+          }
+        }
       }
 
       _updateItem(row, item) {

diff --git a/test/basic.html b/test/basic.html
@@ -352,6 +352,18 @@
             expect(grid.$.scroller.getBoundingClientRect().width).to.be.closeTo(300 - 2, 1);
           });
 
+          it('should have a visible header after row reorder', done => {
+            grid.querySelector('vaadin-grid-column').header = 'header';
+            grid.scrollToIndex(300);
+            setTimeout(() => {
+              flushGrid(grid);
+              const {left, top} = grid.getBoundingClientRect();
+              const cell = grid._cellFromPoint(left + 1, top + 1);
+              expect(grid.$.header.contains(cell)).to.be.true;
+              done();
+            });
+          });
+
           // Skip this test on iOS 10 since there Safari has a bug that makes this fail (works in iOS 9, 11 and 12)
           (/iPhone OS 10_/.test(navigator.userAgent) ? it.skip : it)('should stretch height', () => {
             expect(grid.getBoundingClientRect().height).to.be.closeTo(200, 1);