Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Make sure children are requested for new expanded parents #2058

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

tomivirkki
Copy link
Member

Fixes #2055

@tomivirkki tomivirkki requested a review from yuriy-fix October 14, 2020 13:05
Copy link
Contributor

@yuriy-fix yuriy-fix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one undesirable side effect:
In Grid flow there is a method that allows to check this fix: scrollToEnd.

With this change it won't actually scroll to the end as _effectiveSize is not yet up to date.
scroll-to-end

@tomivirkki
Copy link
Member Author

There is one undesirable side effect

I don't think it's related to this change (happens even with the linked project without any changes).

But that said, this PR doesn't actually resolve the original issue even though it claims to fix it. I think I'll add another change to the PR so it also continues scrolling after new items get loaded.

@tomivirkki
Copy link
Member Author

Done.

@tomivirkki
Copy link
Member Author

Reverted the latest change based on follow-up discussions. Having the grid automatically continue scrolling after child items (and possibly their child items) are received from the server, might be unexpected for the user. Especially with slow connections.

We also discussed having a separate feature, say grid.stickToBottom = true, that would enable the grid to always stick to the bottom scroll position on size changes.

@tomivirkki tomivirkki merged commit 98deb3f into master Oct 16, 2020
@tomivirkki tomivirkki deleted the fix-scroll-to-expanded branch October 16, 2020 09:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeGrid expand does not expand the node at the bottom of the grid
2 participants