Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Cherrypick cell focus event #2196

Merged
merged 3 commits into from
Oct 28, 2021
Merged

Cherrypick cell focus event #2196

merged 3 commits into from
Oct 28, 2021

Conversation

roastedcpu
Copy link
Contributor

Description

Cherry pick V21's cell focus event
#1536
vaadin/web-components#176

Fixes # N/A

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@CLAassistant
Copy link

CLAassistant commented Oct 15, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@roastedcpu roastedcpu mentioned this pull request Oct 18, 2021
Merged
9 tasks
@sissbruecker
Copy link
Contributor

@roastedcpu Please add a valid email address to your commits, so that the CLA can be signed.

@roastedcpu roastedcpu force-pushed the cherrypick-cellfocus-event branch from bf187c9 to 8a40808 Compare October 26, 2021 12:45
@roastedcpu
Cerrypicked cell focus event
c38e345 
dummy commit just to sign it

dummy commit just to sign it

dummy commit just to sign it
@roastedcpu roastedcpu force-pushed the cherrypick-cellfocus-event branch from 8a40808 to c38e345 Compare October 26, 2021 12:45
sissbruecker
sissbruecker approved these changes Oct 26, 2021
View reviewed changes
Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good now. Still need to figure out how to make this land in 14.8 only. PR should not be merged until then.

@DiegoCardoso DiegoCardoso merged commit efc8fdf into vaadin:master Oct 28, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yuriy-fix yuriy-fix yuriy-fix left review comments

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roastedcpu @CLAassistant @sissbruecker @yuriy-fix @DiegoCardoso