fix: prevent unnecessary page fetches when scrolling to index #2203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
force-pushed
the
fix/prevent_unnecessary_page_fetches
branch
from
5cbdc32 to
5a7d5b7
Compare
tomivirkki
approved these changes
Dec 20, 2021
sissbruecker
force-pushed
the
fix/prevent_unnecessary_page_fetches
branch
from
5a7d5b7 to
6be408c
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the grid running into an infinite loop of data provider requests / scroll requests, when clearing items from the cache. This issue occurs in the Flow component, which clears items from the cache after loading new pages. This lead to the web component's scrollToIndex function to request the items for the previous viewport again, when then in turn causes the Flow component to clear the cache for the new viewport...and so on. The fix is to ensure that the grid does not request items for the previous viewport.
Fixes vaadin/flow-components#2352
Type of change