fix: workaround a Safari sticky positioning issue #2069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
reviewed
May 31, 2021
packages/vaadin-virtual-list/src/virtualizer-iron-list-adapter.js
Outdated
Show resolved
Hide resolved
vursen
approved these changes
May 31, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #321
Open https://vaadin.com/docs/latest/ds/components/grid Scroll any of the grids on Safari and the header disappears once the scrolling stops (as the DOM rows get reordered)
The original fix to the issue was removed because it wasn't caught by any of the tests with the new architecture. Turns out the issue was still there but the test just needed a change in timing. This PR restores the original fix.