PR -> comment #1

packages/grid-pro/src/vaadin-grid-pro-inline-editing-mixin.d.ts

@@ -40,5 +40,14 @@ export declare class InlineEditingMixinClass {
 
   protected _switchEditCell(e: KeyboardEvent): void;
 
-  public editCell(row: Number, col: Number, userOriginated: Boolean): void;
+  /**
+   * Triggers the editor for a given (row,col)
+   * row can be either a number (element index) or an object
+   * with the property 'key' = index+1 (e.g. {key: 1} is equivalent to pass it 0)
+   * column can be either a number (element index) or a string (columnId)
+   * @param {number|object} row
+   * @param {number|string} col
+   * @public
+   */
+  editCell(row: number|object, col: number|string): void;
 }

packages/grid-pro/src/vaadin-grid-pro-inline-editing-mixin.js

@@ -456,16 +456,11 @@ export const InlineEditingMixin = (superClass) =>
     }
 
     /**
-     * @param {Number | String} row
-     * @param {Number | String} col
-     * @param {Boolean} userOriginated
+     * @param {number|object} row
+     * @param {number|string} col
      * @public
      */
-    editCell(row, col, userOriginated) {
-      if (userOriginated && this.hasAttribute('disabled')) {
-        throw new Error('Grid is disabled.');
-      }
-
+    editCell(row, col) {
       const columns = this._getColumns().filter((col) => !col.hidden);
 
       let colIdx = -1;

packages/grid-pro/test/edit-column-renderer.test.js

@@ -317,17 +317,6 @@ describe('edit column renderer', () => {
       flushGrid(grid);
     });
 
-    it('enter edit mode programatically should fail for user originated call when grid is disabled', () => {
-      grid.setAttribute('disabled', true);
-      expect(() => {
-        grid.editCell(10, 10, true);
-      }).to.throw(Error, 'Grid is disabled.');
-
-      expect(() => {
-        grid.editCell(0, 0, false);
-      }).to.not.throw(Error, 'Grid is disabled.');
-    });
-
     it('enter edit mode programatically should fail for non-existing indexes', () => {
       expect(() => {
         grid.editCell(0, 10, false);
@@ -376,28 +365,28 @@ describe('edit column renderer', () => {
       }).to.throw(Error, 'Column is not editable');
     });
 
-    it('enter edit mode programatically (x,y) should call _startEdit', () => {
+    it('enter edit mode programatically (x,y) should show the editor', () => {
       const cell = getContainerCell(grid.$.items, 0, 0);
       grid.editCell(0, 0, false);
       const editor = getCellEditor(cell);
       expect(editor).to.be.ok;
     });
 
-    it('enter edit mode programatically (x,colId) should call _startEdit', () => {
+    it('enter edit mode programatically (x,colId) should show the editor', () => {
       const cell = getContainerCell(grid.$.items, 0, 0);
       grid.editCell(0, 'name', false);
       const editor = getCellEditor(cell);
       expect(editor).to.be.ok;
     });
 
-    it('enter edit mode programatically (rowKey,y) should call _startEdit', () => {
+    it('enter edit mode programatically (rowKey,y) should show the editor', () => {
       const cell = getContainerCell(grid.$.items, 0, 0);
       grid.editCell({ key: 1 }, 0, false);
       const editor = getCellEditor(cell);
       expect(editor).to.be.ok;
     });
 
-    it('enter edit mode programatically (rowKey,colId) should call _startEdit', () => {
+    it('enter edit mode programatically (rowKey,colId) should show the editor', () => {
       const cell = getContainerCell(grid.$.items, 0, 0);
       grid.editCell({ key: 1 }, 'name', false);
       const editor = getCellEditor(cell);