fix: allow to prevent creating default slotted buttons #7181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/crud-no-default-buttons
branch
from
ee566cd to
7277353
Compare
web-padawan
force-pushed
the
fix/crud-no-default-buttons
branch
from
7277353 to
cdf6b0f
Compare
|
vursen
approved these changes
Mar 11, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 11, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 11, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 11, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha15 and is also targeting the upcoming stable 24.4.0 version. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of vaadin/flow-components#6080
This PR adds a flag that can be set by the Flow counterpart in the
Crudconstructor like this:As a result, the web component will not create default buttons and expect the server to provide them.
To do this, we set
tagNameinSlotControllerconstructor tonull(see e.g.HelperController).Type of change