Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

refactor: use correct property bindings in Lit based login form #8335

Merged
merged 1 commit into from
Dec 13, 2024
Merged

refactor: use correct property bindings in Lit based login form #8335

merged 1 commit into from
Dec 13, 2024

Conversation

web-padawan
Copy link
Member

Description

Updated to bind label using property and use ifDefined() directive to set action on the <form> element.

Type of change

  • Refactor

@web-padawan web-padawan requested a review from vursen December 12, 2024 14:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@web-padawan web-padawan merged commit 849dc36 into main Dec 13, 2024
9 checks passed
@web-padawan web-padawan deleted the refactor/lit-property-binding branch December 13, 2024 08:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vursen vursen vursen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@web-padawan @vursen