Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: replace onceResized with nextResize #8387

Merged
merged 16 commits into from
Dec 23, 2024
Merged

test: replace onceResized with nextResize #8387

merged 16 commits into from
Dec 23, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Dec 23, 2024

Description

Replaces onceResized test helpers with nextResize, which subscribes to a real ResizeObserver instead of spying for internal component methods. Apart from cleaning up tests, this change also fixes Webkit failures in #8355.

Depends on

Type of change

  • Internal

@vursen vursen marked this pull request as ready for review December 23, 2024 08:53
@vursen vursen requested a review from web-padawan December 23, 2024 09:39
@vursen vursen merged commit 4af9e19 into main Dec 23, 2024
9 checks passed
@vursen vursen deleted the test/use-next-resize branch December 23, 2024 10:05
@vaadin-bot
Copy link
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.6, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4af9e19
error: could not apply 4af9e19... test: replace onceResized with nextResize (#8387)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @vursen and @vursen, when i performed cherry-pick to this commit to 24.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4af9e19
error: could not apply 4af9e19... test: replace onceResized with nextResize (#8387)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants