Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: do not stop ignored dragleave events in grid #8500

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

tomivirkki
Copy link
Member

@tomivirkki tomivirkki commented Jan 13, 2025

Description

Grid currently stops the propagation of all native "dragleave" events which causes the issue. The propagation of "dragleave" event should only be stopped if the grid has a dropMode, in which case corresponding "dragover" and "dragenter" events are also processed by the grid dnd logic

Fixes #8476

Type of change

  • Bugfix

@tomivirkki tomivirkki marked this pull request as ready for review January 13, 2025 11:31
@tomivirkki tomivirkki changed the title fix: do not stop ignored native dnd events in grid fix: do not stop ignored dragleave events in grid Jan 13, 2025
@tomivirkki tomivirkki merged commit 09164e2 into main Jan 13, 2025
9 checks passed
@tomivirkki tomivirkki deleted the fix/grid-ignored-dnd-events branch January 13, 2025 11:41
web-padawan pushed a commit that referenced this pull request Jan 13, 2025
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
web-padawan pushed a commit that referenced this pull request Jan 13, 2025
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@mshabarov
Copy link
Contributor

mshabarov commented Jan 13, 2025

@tomivirkki could we also pick this to 24.4 ?
It's EOL soon and would be great to release this fix as well in the last release of this branch.

@tomivirkki
Copy link
Member Author

@mshabarov cherry-picked here #8503

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.alpha5 and is also targeting the upcoming stable 24.7.0 version.

web-padawan pushed a commit that referenced this pull request Feb 5, 2025
Co-authored-by: Tomi Virkki <tomivirkki@users.noreply.github.com>
@vaadin-bot
Copy link
Collaborator

Hi @tomivirkki and @tomivirkki, when i performed cherry-pick to this commit to 23.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 09164e2
The previous cherry-pick is now empty, possibly due to conflict resolution.
If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'

@web-padawan
Copy link
Member

This was backported manually to 23.5 via #8640

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v-drag-over-target is not removed when the drop is ending in a Vaadin Grid
5 participants