Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: upgrade SauceLabs launcher to the latest version (#8573) (CP: 23.5) #8615

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

web-padawan
Copy link
Member

Description

Manual cherry-pick of #8573 to 23.5 branch.

Web Test Runner dependencies in 23.5 branch were outdated so I updated them too.

Type of change

  • Cherry-pick

Note

I had to enable 'wdio:enforceWebDriverClassic' option since 23.5 uses Chrome 88 which doesn't support BiDi protocol used by default in Webdriver 9.

@web-padawan
Copy link
Member Author

Tooltip tests also fail locally. I'll investigate it and maybe create a separate PR to bump other WTR dependencies first.

@web-padawan web-padawan marked this pull request as draft February 3, 2025 10:33
@web-padawan web-padawan force-pushed the cp/sauce-launcher-bump-23.5 branch from da5ec17 to 7216a7a Compare February 3, 2025 14:22
@web-padawan
Copy link
Member Author

Looks like failing tests in tooltip-timers.test.js were caused by some accidental mouseenter event:

  • Calling resetMouse() somewhere in other test file moves mouse to the position 0, 0 - see docs,
  • Then the tooltip test file (presumably?) loads in the same browser session where mouse was reset,
  • The <input> element used as a target e.g. in focusDelay test is also positioned at coordinates 0, 0
  • And it gets mouseenter event with isTrusted: true which causes the tooltip to open immediately.

I noticed that yarn upgrade caused puppeteer to be updated to latest (23.11.11), maybe it's related.
Reverted it for now to 23.3.0 which is a version installed in main branch, let's see if that helps 🤞

@web-padawan web-padawan force-pushed the cp/sauce-launcher-bump-23.5 branch from 8802488 to a8827c2 Compare February 4, 2025 09:29
Copy link

sonarqubecloud bot commented Feb 4, 2025

@web-padawan web-padawan removed the request for review from vursen February 4, 2025 10:58
@web-padawan web-padawan merged commit df13756 into 23.5 Feb 4, 2025
10 checks passed
@web-padawan web-padawan deleted the cp/sauce-launcher-bump-23.5 branch February 4, 2025 10:59
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 23.5.15.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants