fix: bring popover overlay to front when used in modeless dialog #8692
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
fix/popover-modeless-dialog
branch
from
7c269f6 to
0840602
Compare
|
sissbruecker
approved these changes
Feb 20, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8521
Depends on #8690
Type of change
Note
For now the
vaadin-popoveris the only web component where the original issue can be reproduced. Other components e.g.vaadin-combo-boxhave their overlays as modal by default. Thevaadin-tooltipis modeless but should close on mousedown regardless. So for now I thought the fix can be limited to the popover package.If we decide to add public API for making overlays non-modal (see #451) then we should reconsider this fix as the issue would then likely affect other components using overlays as well.