Skip to content
This repository was archived by the owner on Jun 25, 2023. It is now read-only.

Parallels provider support #42

Merged
merged 2 commits into from
Mar 24, 2014

Conversation

legal90
Copy link
Contributor

@legal90 legal90 commented Mar 20, 2014

I've added and tested a compatibility with Parallels provider.
I'm ready to support this further.

P.s. I've implemented it using the host_address provider capability, which is available in 'vagrant-parallels' v1.0.3 and later. That's why I've added a version checking. Please, let me know if you have any suggestion about that.

@legal90
Copy link
Contributor Author

legal90 commented Mar 24, 2014

How do you like it, @phinze?

@phinze
Copy link
Contributor

phinze commented Mar 24, 2014

wow @legal90 this is great! pulling this in now and cutting a release.

I'm ready to support this further.

wonderful! would you like contributor status to the project to continue to help out?

phinze added a commit that referenced this pull request Mar 24, 2014
@phinze phinze merged commit eea35dd into vagrant-landrush:master Mar 24, 2014
@legal90
Copy link
Contributor Author

legal90 commented Mar 25, 2014

wonderful! would you like contributor status to the project to continue to help out?

It's up to you. Anyway, I will prefer to use pull requests instead committing without a review :)

This is just doing string comparison yes? So if the parallels provider hits 1.0.10 the condition will eval to true.

Oh.. You're right, sorry. Seems like I have to use comparison of Gem::Version instances. I'll fix it

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants