Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Ghana Tax ID Validation #76

Closed

Conversation

assetcorp
Copy link

Add Ghana Tax ID Validation Support

Changes

  • Added validation for Ghana Tax Identification Numbers (TIN)
    • Format: C/P followed by 10 digits (e.g., C0123456789)
  • Added validation for Ghana Card numbers
    • Format: GHA-XXXXXXXXX-Y where X are digits and Y is a check digit

@valeriansaliou
Copy link
Owner

valeriansaliou commented Jan 1, 2025

Thanks for this PR! Since VAT ID number validation is not a flagship feature of this library (and is not used by all users of this library), I'd like to keep it simple by handling it for economic areas only (eg. EU).

Unfortunately, accepting Ghana Tax ID validation opens a way for Tax ID validation for much more countries, which will ultimately result in code complexification.

I therefore believe Tax ID validation, if done on a country level, should be the scope of another separate library, which this one could in turn use. Eg. a node-tax-id-validator library.

@assetcorp
Copy link
Author

Thanks for this PR! Since VAT ID number validation is not a flagship feature of this library (and is not used by all users of this library), I'd like to keep it simple by handling it for economic areas only (eg. EU).

Unfortunately, accepting Ghana Tax ID validation opens a way for Tax ID validation for much more countries, which will ultimately result in code complexification.

I therefore believe Tax ID validation, if done on a country level, should be the scope of another separate library, which this one could in turn use. Eg. a node-tax-id-validator library.

Thank you for your response. I agree that this should be part of a separate package. I will go ahead and close this pull request.

@assetcorp assetcorp closed this Jan 4, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants