Tag smoothness=impassable breaks pedestrian routing

[gknisely]

Issue

Smoothness tag should not delete the edge in general. The smoothness tag is for the physical usability of a way for wheeled vehicles as defined in the wiki and pedestrian access should not be removed.

Tasklist

• Updated tests
• Add fixes Tag smoothness=impassable breaks pedestrian routing #4967
• Update the changelog

Requirements / Relations

Link any requirements here. Other pull requests this PR is based on?

[chrstnbwnkl]

Ah wait, it shouldn't have wheelchair access though right? 😄

wheelchair access on impassable surface

[gknisely]

Ah wait, it shouldn't have wheelchair access though right? 😄

Yes. We use pedestrian access to assign wheelchair when we can do so. https://github.com/valhalla/valhalla/blob/master/src/mjolnir/directededgebuilder.cc#L164-L165

[gknisely]

@chrstnbwnkl Let me update the directed edge builder and test

[chrstnbwnkl]

I guess it doesn't matter because wheelchair will still be disallowed due to the surface value?

valhalla/src/sif/pedestriancost.cc

Lines 590 to 595 in a0c27bc

	if (type == "wheelchair") {
	// TODO(nils): this needs to control much more in costing, e.g.
	// we could add more AccessRestrictions for curb height or so
	type_ = PedestrianType::kWheelchair;
	access_mask_ = kWheelchairAccess;
	minimal_allowed_surface_ = Surface::kCompacted;

[gknisely]

I guess it doesn't matter because wheelchair will still be disallowed due to the surface value?

valhalla/src/sif/pedestriancost.cc

Lines 590 to 595 in a0c27bc

	if (type == "wheelchair") {
	// TODO(nils): this needs to control much more in costing, e.g.
	// we could add more AccessRestrictions for curb height or so
	type_ = PedestrianType::kWheelchair;
	access_mask_ = kWheelchairAccess;
	minimal_allowed_surface_ = Surface::kCompacted;

Nah. I think it is better to not assign. Give me a few

[gknisely]

@chrstnbwnkl should be all set