Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: (isMobilePhone) add Cyprus validation #1897

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

ikerasiotis
Copy link
Contributor

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #1897 (9cfd06a) into master (f055c11) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2072      2072           
  Branches       472       472           
=========================================
  Hits          2072      2072           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f055c11...9cfd06a. Read the comment docs.

profnandaa
profnandaa previously approved these changes Apr 22, 2022
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution 🎉

// And sorry for the delay in reviewing this.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Apr 22, 2022
@profnandaa
Copy link
Member

Just fix the m/c on README and we should be good to go.

@rubiin rubiin merged commit 3873ebf into validatorjs:master Jul 19, 2022
@rubiin
Copy link
Member

rubiin commented Jul 19, 2022

Thankyou for the contribution 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants