Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(isMobilePhone): added Saint Kitts and Nevis mobile number validation (en-KN) #2011

Merged
merged 1 commit into from
Oct 17, 2022
Merged

feat(isMobilePhone): added Saint Kitts and Nevis mobile number validation (en-KN) #2011

merged 1 commit into from
Oct 17, 2022

Conversation

Eelyneee
Copy link
Contributor

Added Saint Kitts and Nevis mobile number validation (en-KN)

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@rubiin rubiin requested a review from profnandaa July 27, 2022 15:45
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #2011 (814430e) into master (1bb14e8) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2011   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2203      2203           
  Branches       477       477           
=========================================
  Hits          2203      2203
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bb14e8...814430e. Read the comment docs.

@rubiin rubiin added the ready-to-land For PRs that are reviewed and ready to be landed label Jul 27, 2022
profnandaa
profnandaa approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contrib! 🎉

@profnandaa profnandaa merged commit 2c785a5 into validatorjs:master Oct 17, 2022
@profnandaa profnandaa mentioned this pull request Feb 2, 2023
Closed
@rntvicente rntvicente mentioned this pull request May 24, 2024
Open
@sahilpawar58 sahilpawar58 mentioned this pull request May 25, 2024
Open
@ChinmoyHembram ChinmoyHembram mentioned this pull request May 25, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

@rubiin rubiin rubiin approved these changes

Assignees
No one assigned
Labels
🎉 first-pr ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eelyneee @profnandaa @rubiin