-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test(validators): remove duplicated test block from isMobilePhone #2137
test(validators): remove duplicated test block from isMobilePhone #2137
Conversation
not sure what happened there, when this was committed with 2e6cc37 The test here is just a "merged" test of the individual en-ZA and be-BY tests. The individual tests themselves for en-ZA and be-BY are also still there and valid.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2137 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
The removed test block here is just a "merged" test of the individual en-ZA and be-BY tests for isMobilePhone.
The individual tests themselves for en-ZA and be-BY are also still there and valid and remain untouched by this PR.
Not really sure what exactly happened there, when this was committed with 2e6cc37, all I know is, that we should remove it
Checklist
[ ] README updated (where applicable)[ ] Tests written (where applicable)