Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test(validators): remove duplicated test block from isMobilePhone #2137

Merged

Conversation

pano9000
Copy link
Contributor

The removed test block here is just a "merged" test of the individual en-ZA and be-BY tests for isMobilePhone.
The individual tests themselves for en-ZA and be-BY are also still there and valid and remain untouched by this PR.

Not really sure what exactly happened there, when this was committed with 2e6cc37, all I know is, that we should remove it

Checklist

  • PR contains only changes related; no stray files, etc.
  • [ ] README updated (where applicable)
  • [ ] Tests written (where applicable)

not sure what happened there, when this was committed with 2e6cc37
The test here is just a "merged" test of the individual en-ZA and be-BY tests.
The individual tests themselves for en-ZA and be-BY are also still there and valid.
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8cbd2d2) compared to base (531dc7f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2137   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rubiin rubiin added ready-to-land For PRs that are reviewed and ready to be landed ✅ LGTM labels Jan 21, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@profnandaa profnandaa merged commit f394da0 into validatorjs:master Jan 22, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
✅ LGTM ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants