Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(isLicensePlate): Support for Pakistani vehicles #2207

Merged
merged 3 commits into from
Apr 25, 2024

Conversation

anasshakil
Copy link
Contributor

This PR adds support for Pakistani vehicles license plates.

const isValid = isLicensePlate('IDS 7871', 'en-PK'); // valid

Supported formats

  • X YYYY
  • XXX YYY
  • XXX-YYY
  • XXX YYYY
  • XXYYYY
  • XX YYY
  • XXYYY
  • XXX YYYY YY
  • XXX YYY-YY
  • XXX-YYY-YY
  • XXXX YYYY YY

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)
  • References provided in PR (where applicable)

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 ⚠️

Comparison is base (cb91971) 100.00% compared to head (65ce01a) 99.95%.

Additional details and impacted files
@@             Coverage Diff             @@
##            master    #2207      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files          106      107       +1     
  Lines         2348     2406      +58     
  Branches       593      604      +11     
===========================================
+ Hits          2348     2405      +57     
- Partials         0        1       +1     
Impacted Files Coverage Δ
src/lib/isLicensePlate.js 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anasshakil anasshakil changed the title Pakistan License Plate Support feat(isLicensePlate): Support for Pakistani vehicles Mar 22, 2023
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, LGTM. Thanks for your contrib! 🎉

@profnandaa profnandaa added 🧹 needs-update For PRs that need to be updated before landing ✅ LGTM labels Mar 27, 2023
@rubiin rubiin requested a review from profnandaa April 24, 2023 20:06
@profnandaa profnandaa merged commit 32b174e into validatorjs:master Apr 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
✅ LGTM 🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants