Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add guatemala phone number #2395

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

ignaciosuarezquilis
Copy link
Contributor

feat(isMobilePhone.js): add guatemala phone number

'es-GT': /^(+?502)?[2|6|7]\d{7}$/,

(https://www.llamarfuera.com/llamadas/guatemala.html)

@rubiin
Copy link
Member

rubiin commented May 12, 2024

Add tests, update readme plz @ignaciosuarezquilis

@rubiin rubiin added the 🧹 needs-update For PRs that need to be updated before landing label May 12, 2024
@ignaciosuarezquilis
Copy link
Contributor Author

Add tests, update readme plz @ignaciosuarezquilis

Hi, I already updated the readme. I don't know how to add tests, it passed the automatic tests and I ran npm test and this is what I get:

259 passing (537ms)

=============================== Coverage summary ===============================
Statements : 100% ( 2630/2630 )
Branches : 97.33% ( 1602/1646 )
Functions : 100% ( 410/410 )
Lines : 100% ( 2322/2322 )

@rubiin
Copy link
Member

rubiin commented May 14, 2024

The files changed doesnt show any modifications to readme file. Do check again .
To add tests you can simply see reference here

locale: 'fa-AF',
valid: [
'0511231231',
'+93511231231',
'+93281234567',
],
invalid: [
'212528812312123',
'+212-5290-12312',
'++212528812312',
'12345',
'Afghanistan',
'this should fail',
'212 5288---12312',
'+503 1111 1111',
'00 +503 1234 5678',
],

Just add valid and invalid numbers as shown for other countries

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (83d6ffd) to head (c2a6f3c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2395   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          108       109    +1     
  Lines         2482      2489    +7     
  Branches       627       628    +1     
=========================================
+ Hits          2482      2489    +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ignaciosuarezquilis
Copy link
Contributor Author

I already made the changes and ran the test. Thanks for your help and let me know if there is something else to do.

@rubiin rubiin added 🧹 needs-update For PRs that need to be updated before landing ✅ LGTM and removed 🧹 needs-update For PRs that need to be updated before landing labels May 15, 2024
@rubiin
Copy link
Member

rubiin commented May 15, 2024

Thanks

@rubiin rubiin removed the 🧹 needs-update For PRs that need to be updated before landing label May 15, 2024
@ignaciosuarezquilis
Copy link
Contributor Author

Excuse me, I don't understand if there is something more I need to do to get the pull request approved, or if I just have to wait.

@rubiin
Copy link
Member

rubiin commented May 18, 2024

Lets wait for merge. Everything looks good

@rubiin rubiin requested a review from profnandaa May 18, 2024 07:11
@ignaciosuarezquilis
Copy link
Contributor Author

Sorry for asking again, but is there any way to expedite the process? I need to show the contribution for a project at the university. Thanks.

@rubiin
Copy link
Member

rubiin commented May 21, 2024

@profnandaa

@ignaciosuarezquilis
Copy link
Contributor Author

@profnandaa Sorry for asking again. I would like to ask if there is any possibility to get the pull request approved because I need it for a university project. Thank you.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contrib, LGTM!

@profnandaa profnandaa merged commit e3a9db1 into validatorjs:master Jun 1, 2024
12 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants