-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add guatemala phone number #2395
add guatemala phone number #2395
Conversation
Add tests, update readme plz @ignaciosuarezquilis |
Hi, I already updated the readme. I don't know how to add tests, it passed the automatic tests and I ran npm test and this is what I get: 259 passing (537ms) =============================== Coverage summary ===============================
|
The files changed doesnt show any modifications to readme file. Do check again . validator.js/test/validators.test.js Lines 10059 to 10075 in 79f5d18
Just add valid and invalid numbers as shown for other countries |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2395 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 108 109 +1
Lines 2482 2489 +7
Branches 627 628 +1
=========================================
+ Hits 2482 2489 +7 ☔ View full report in Codecov by Sentry. |
I already made the changes and ran the test. Thanks for your help and let me know if there is something else to do. |
Thanks |
Excuse me, I don't understand if there is something more I need to do to get the pull request approved, or if I just have to wait. |
Lets wait for merge. Everything looks good |
Sorry for asking again, but is there any way to expedite the process? I need to show the contribution for a project at the university. Thanks. |
@profnandaa Sorry for asking again. I would like to ask if there is any possibility to get the pull request approved because I need it for a university project. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contrib, LGTM!
feat(isMobilePhone.js): add guatemala phone number
'es-GT': /^(+?502)?[2|6|7]\d{7}$/,
(https://www.llamarfuera.com/llamadas/guatemala.html)