Skip to content

Commit

Permalink
chore: update copy for deposit to unknown app (#6298)
Browse files Browse the repository at this point in the history
### Description

It may be unavoidable that some dapps that we do not know about create
transactions that are parsed as deposits / withdraws etc. The "unknown
dapp" message reads a little bit like an error (and was flagged as such
at bugapalooza,
[context](https://valora-app.slack.com/archives/C04B61SJ6DS/p1733248109384319?thread_ts=1733245811.844689&cid=C04B61SJ6DS))
so this PR updates the copy. Open for other suggestions too.

### Test plan

n/a

### Related issues
n/a

### Backwards compatibility

Y
### Network scalability

If a new NetworkId and/or Network are added in the future, the changes
in this PR will:

- [ ] Continue to work without code changes, OR trigger a compilation
error (guaranteeing we find it when a new network is added)
  • Loading branch information
kathaypacific authored Dec 4, 2024
1 parent 06bf2ee commit 35dcd31
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions locales/base/translation.json
Original file line number Diff line number Diff line change
Expand Up @@ -2293,13 +2293,13 @@
"crossChainSwapTransactionLabel": "Cross-chain",
"depositTitle": "Deposited",
"depositSubtitle": "to {{txAppName}} Pool",
"depositSubtitle_noTxAppName": "to unknown app",
"depositSubtitle_noTxAppName": "to an app",
"withdrawTitle": "Withdrew",
"withdrawSubtitle": "from {{txAppName}} Pool",
"withdrawSubtitle_noTxAppName": "from unknown app",
"withdrawSubtitle_noTxAppName": "from an app",
"claimRewardTitle": "Collected",
"claimRewardSubtitle": "from {{txAppName}} Pool",
"claimRewardSubtitle_noTxAppName": "from unknown app",
"claimRewardSubtitle_noTxAppName": "from an app",
"allTransactionsShown": "You've reached the end of your transaction history.",
"fetchErrorRetry": "Try again",
"error": {
Expand All @@ -2311,15 +2311,15 @@
"descriptionLabel": "Details",
"depositTitle": "Deposited",
"depositSubtitle": "Deposited {{tokenSymbol}} to {{txAppName}} Pool",
"depositSubtitle_noTxAppName": "Deposited {{tokenSymbol}} to unknown app",
"depositSubtitle_noTxAppName": "Deposited {{tokenSymbol}} to an app",
"depositDetails": "Amount Deposited",
"withdrawTitle": "Withdrew",
"withdrawSubtitle": "Withdrew {{tokenSymbol}} from {{txAppName}} Pool",
"withdrawSubtitle_noTxAppName": "Withdrew {{tokenSymbol}} from unknown app",
"withdrawSubtitle_noTxAppName": "Withdrew {{tokenSymbol}} from an app",
"withdrawDetails": "Amount Withdrawn",
"claimRewardTitle": "Collected",
"claimRewardSubtitle": "Collected {{tokenSymbol}} from {{txAppName}} Pool",
"claimRewardSubtitle_noTxAppName": "Collected {{tokenSymbol}} from unknown app",
"claimRewardSubtitle_noTxAppName": "Collected {{tokenSymbol}} from an app",
"claimRewardDetails": "Amount Collected",
"swap": "Swap",
"network": "Network",
Expand Down

0 comments on commit 35dcd31

Please # to comment.