-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Warn users if provider does not support current location #102
Conversation
This reverts commit 2597bec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like a much better solution than what we had before 🙌
Left a couple small comments 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! 👍
Left some small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Hi jean , gn I have verified this issue using latest latest Android Internal Build V1.12.0(1004294340) & Test flight build V1.12.0(49) & observed following:
Verified on devices: Samsung Galaxy A5(7.0), iPhone XR (14.2) Let me know needful for above points . Thanks..!! |
cc: @tarikbellamine |
Hi @Celoqa! The important thing to test here is if the grey text in the screenshot ("Limited support in region") is shown where appropriate. The list of which options should show "limited support in region" is available here: https://github.com/celo-org/wallet/blob/main/packages/mobile/src/flags.ts#L54 For example, the text should appear for Moonpay if the user is in the US. It should not appear for Ramp if the user is in France. |
Hey @tarikbellamine I have re-verified this issue using Android Internal Build V1.12.0(1004294340) & Test flight build V1.12.0(49) & observed following.
Verified on devices: Samsung Galaxy A5(7.0), iPhone XR (14.2) |
This is difficult to test because we determine location based off of IP address. You will need a VPN to connect through a restricted country in order to test. I think you can skip this for now but we should revisit how to best test this functionality. |
HI @tarik here we have tested this task by using Tunnel bear VPN app and observed some countries are shown warm messages with grey text. Able to see Grey text on Moonpay when user is on below given countries
Able to see Grey text on Ramp when user is on below given countries
Able to see Grey text on Transak when user is on below given countries
Note: We have only some countries which are available in Tunnel bear So, we have tested countries which are available in Tunnel bear for now. Can you please let us know if you want to cover any specific country, We can try to cover. |
This is good, thank you! |
Always a pleasure @tarikbellamine |
Description
Using the MoonPay
ipAddress
endpoint, we are determining what country/state a user is currently located. Using that location, we conditionally render a warning on each provider on theProviderOptionsScreen
rather than hide providers that may not be accessible.To Do: Update the restricted country list for each provider
Other changes
N/A
Tested
Yes
Related issues
Backwards compatibility
Yes