Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Bitfy and FlowBTC as providers for Brazil #132

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Add Bitfy and FlowBTC as providers for Brazil #132

merged 2 commits into from
Mar 17, 2021

Conversation

gnardini
Copy link
Contributor

@gnardini gnardini commented Mar 17, 2021

Description

Added two new cash in/out providers for Brazil. These integrations are just a link to a WebView for those providers like the ones we have for Ponto and Kotani.

Other changes

N/A

Tested

Manually by using a BR number (and checking it doesn't show up for other countries)

Related issues

Backwards compatibility

N/A

@gnardini gnardini requested a review from tarikbellamine March 17, 2021 19:08
Copy link
Contributor

@tarikbellamine tarikbellamine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work given the time crunch! Eventually, we may want to revisit our strategy for remote enabling providers and potentially restructure this a bit :)

@ValoraQA
Copy link

Hi @tarikbellamine I have tried to verify this issue using Android Internal Build V1.12.0(1004294340) & Test flight build V1.12.0(49) & observed following.
Observations:

  • Non-verified Brazil user not able to see "Bitfy and FlowBTC" providers.

  • Also it is observed that, start button not get enabled even user entered correct Brazil number while confirming phone number. Start button only enabled after entering 55 two times. Hence, we blocked to verify this issue by verifying phone number. Please refer attachment.
    Attachment: UserNotProceedForBrazilNumber.mp4
    Verified on Devices: Samsung Galaxy A5(7.0), iPhone XR (14.2)

Let me please know if anything need to test.

@gnardini
Copy link
Contributor Author

@Celoqa It's not necessary to verify the Brazilian number, after putting it in like you did you should see Bitfy and FlowBTC.

@ValoraQA
Copy link

Hey @gnardini I have verified this issue & observed following:
Observations:

  • We are able to see Bitfy and FlowBTC providers for Alfrajos Wallet (49) version in iOS.

Attachment: BitfyAndFlowBTCOnlyForAlfajoresVersion.png

  • As of now we not able to see Alfrajos version for android. Will update for android when we will receive this version.

  • We are not able to see same for Mainnet version for both android as well as iOS.

@ValoraQA
Copy link

Hey @gnardini Can you please let us know if any updates for Android Alfrajos version so that we can test UI changes for android also.
Thanks..!!

@gnardini
Copy link
Contributor Author

gnardini commented Mar 30, 2021

Hi @Celoqa!
The alfajores version should be available on the Play Store. It's under the name Celo Alfajores Wallet - TEST ONLY. The version is 1.12.1. Let me know if you can't see it!

Edit: Version is 1.12.1 not 12.0.1

@ValoraQA
Copy link

ValoraQA commented Mar 31, 2021

Hi @gnardini
We are able to see Celo Alfajores Wallet - TEST ONLY. The version is 1.9.0 not able to see 12.0.1.

Can you please do the needful.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Local CICO options in Brazil to the Add/Withdraw Flow
3 participants