Enable short verification codes remotely and related UI facelift

[i1skn]

Description

Enable short verification codes remotely and related UI facelift

Tested

iOS & Android both with enabled and disabled feature

Related issues

• Fixes 8-digit attestation code celo-org/celo-monorepo#6631

Backwards compatibility

Yes

Screenshots

[jeanregisser]

Looking great! 👍 🚀

A couple of points:

• can you test on Android too to be sure it doesn't break anything?
• could you add screenshots so it's easier to review the UI changes?

[jeanregisser]

I think we also want keyboardType to be number-pad when shortVerificationCodesEnabled is true, right?

[i1skn]

@jeanregisser great suggestions!
I've tested it on Android and also changed keyboard to numeric on iOS.
Also have added screenshot to the description!

[jeanregisser]

Don't we want number-pad too on Android?

[i1skn]

I'm slightly worried about the comment above autoCorrect={false}, which starts with // This disables keyboard suggestions on iOS, but unfortunately NOT on Android .... So, I'm hesitant to replacevisible-password with number-pad. WDYT?

[jeanregisser]

Yes I was fighting to disable autoCorrect on Android.
But here using number-pad should be safe on both iOS and Android when shortVerificationCodesEnabled is true.
And we can keep the existing logic when it's false.

[ValoraQA]

Hi @i1skn we have verified this task using latest Android Internal Build V1.12.0(1004294340) & Test flight build V1.12.0(49) and observed the followings.

• User is able to receive 8 digit verification codes and able to compete the verification flow.

User is able to receive 8 digit verification codes and able to complete the verification flow when user go through below scenarios:

• Able to receive 8 digits verification codes & able to complete verification flow on-Boarding flow.
• Able to complete verification flow when user go through restore my account key.
• Able to complete verification flow when user go through Confirm phone number in-App notification.
• Able to complete verification flow when user go through settings> Confirm phone number
• Able to complete verification flow when user go through Earn rewards> Confirm phone number.

Observation: Confirmation error message is shown on confirming screen when user keep the app in background while receiving codes,
Can you please let us know is this expected behavior Or we need to raise an issue.

Please let us know if we need to test anything else in this task.

[i1skn]

@Celoqa Thanks for checking it, can you please open an issue with attached logs/video, so I can check is that an expected behaviour or not. Thanks!

[ValoraQA]

Sure @i1skn We will raise a new issue with attached logs.

[ValoraQA]

Hi @i1skn We have raised a new issue with attached logs #146

[i1skn]

Thanks!

[ValoraQA]

Hi @i1skn Can you please confirm below issue is expected Or not if not we can raise a new issue.

• Confirmation failed message is shown when user change the phone number after receiving attestation.
• After receiving codes we are able to see all same alphabets so, can you please confirm it is expected behavior.Attachment
• Also we have observed text difference in code for iOS & Android. Let me know it is expected behavior. Attachment

Build: Android Internal Build V1.12.0(1004294340) & Test flight build V1.12.0(49)
Devices: iPhone 6+ (12.4.5), Samsung M30(10)
Repro steps:

• Install the app
• Go through on-boarding flow
• Enter phone number
• Tap on start button & complete captcha
• Make sure user should receive attestation
• Go back to Phone number page
• Change the phone number
• Tap on resume button
• Observe
  Attachment:
• Confirmation Failed.mp4
• ConfirmationFailedLogs