Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add if outgoing payment request, remove header title with balance #266

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

michellewong793
Copy link
Contributor

@michellewong793 michellewong793 commented Apr 21, 2021

Description

Changes the SendScreen component:
Header is without the balance on the Request Payments Screen.

image

Other changes

none

Tested

tested on android

Related issues

Backwards compatibility

compatible

Copy link
Contributor

@etuleu etuleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Contributor

@gnardini gnardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🙌

@michellewong793 michellewong793 added the automerge Have PR merge automatically when checks pass label Apr 23, 2021
@mergify mergify bot merged commit cc0aad2 into main Apr 23, 2021
@mergify mergify bot deleted the mwong/remove-balance-request-screen branch April 23, 2021 22:35
@ValoraQA
Copy link

ValoraQA commented May 10, 2021

Hi @etuleu I have verified this issue using latest released Android internal build V1.14.0 (1004294350) & Test Flight build V1.14.0(58) & observed following:
Observations:

  • It is observed that, user is able to see Header without the balance on the "Request Payments Screen" using phone number & QR code of User B when user has some balance in account or $0.00 account balance. Attachment

For Verified Phone Number:

  • It is observed that, user able to see "Please confirm your number before sending cUSD to a contact" red validation message displayed when user requesting money with verified phone number using Request Contact Screen.Attachment
    Let me know is this expected or we need to raise a ticket for same ?

  • Also it is observed that, user able to request completely even user has $0.00 balance in verified user's account without any error message through scanning QR code of user B.

For Non-verified Number:

  • It is observed that while requesting through non verified number using Request Contact screen "Please confirm your number before sending cUSD to a contact" red validation message displayed & loading indicator displayed for longer time even user proceeds by tapping on "Review" button. Attachment
    Let me know is this expected or we need to raise a ticket for same ?

  • Also it is observed that, user able to request completely even user has $0.00 balance for non-verified user without any error message through scanning QR code of user B. Attachment

Verified On Devices: iPhone SE (14.2), Redmi Note 8 (9.0), iPhone 6+(12.4.5)
Thanks..!!

@ValoraQA
Copy link

ValoraQA commented Jun 2, 2021

Hey @etuleu Is there any update on above unchecked points ?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
automerge Have PR merge automatically when checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove balance display from Payment Request screen
5 participants