Use account address when giving CIP8 profile access #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarikbellamine
approved these changes
May 12, 2021
gnardini
reviewed
May 12, 2021
| const walletToAccountAddress: WalletToAccountAddressType = yield select( | ||
| walletToAccountAddressSelector | ||
| ) | ||
| const accountAddress = walletToAccountAddress[walletAddress] ?? walletAddress |
There was a problem hiding this comment.
Should we add an endpoint to blockchain-api to do this walletAddress -> accountAddress lookup in case we don't have the mapping in walletToAccountAddress?
i.e. exposing what is done in the transaction feed to get it.
jeanregisser
pushed a commit
that referenced
this pull request
May 12, 2021
### Description If the account address of the recipient is known, use that address to grant CIP8 profile access ### Tested not tested
|
Hi @jeanregisser @isabellewei can you please let us know that we need to test anything here if yes can you please provide some information about this task so, it would be really helpful to us to verify. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the account address of the recipient is known, use that address to grant CIP8 profile access
Tested
not tested