chore(ci): check e2e main commits against Android API level 27
#6031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6031 +/- ##
========================================
Coverage 88.92% 88.92%
========================================
Files 735 735
Lines 31366 31366
Branches 5821 5515 -306
========================================
Hits 27892 27892
Misses 3429 3429
Partials 45 45 Continue to review full report in Codecov by Sentry.
|
bakoushin
changed the title
main commits against Android API level 24main commits against Android API level 27
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
### Description Follow up to #6031 The Android API level must be specified not as a string but as a number, as is expected in [e2e-android.yml](https://github.com/valora-inc/wallet/blob/c6e23572ea8db100a3de9d65f0bae6d3f843b4c3/.github/workflows/e2e-android.yml#L7) ### Test plan CI works ### Related issues - Related to RET-1194 ### Backwards compatibility NA ### Network scalability NA
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want CI to check the app against the highest and lowest supported Android API levels. The highest supported API level is being checked in the PR CI. The lowest level should be checked after merging the PR into a main branch.
Currently, the lowest API level we support is 24, but the levels 24, 25, and 26 are failing the CI for some reason.
Setting Android API level 27 as the lowest one for now.
Test plan
CI succeeds, like in this workflow: 76f5859
Related issues
Backwards compatibility
NA
Network scalability
NA