fix: incorrect withdraw percentage amount #6288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6288 +/- ##
=======================================
Coverage 88.96% 88.96%
=======================================
Files 739 739
Lines 31613 31613
Branches 5883 5883
=======================================
+ Hits 28123 28126 +3
+ Misses 3290 3287 -3
Partials 200 200
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
kathaypacific
added a commit
that referenced
this pull request
Dec 3, 2024
### Description As the title - this was a copy paste error, restoring it to the [previous logic](https://github.com/valora-inc/wallet/blob/7714ddffef3b08d252fa6e6595b4b4114eb7e28c/src/earn/EarnEnterAmount.tsx#L348). ### Test plan Applying the max amount now matches the max amount displayed in the withdraw details. https://github.com/user-attachments/assets/540854a7-9020-4208-930b-e0042c92a025 ### Related issues n/a ### Backwards compatibility Y ### Network scalability If a new NetworkId and/or Network are added in the future, the changes in this PR will: - [ ] Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title - this was a copy paste error, restoring it to the previous logic.
Test plan
Applying the max amount now matches the max amount displayed in the withdraw details.
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-12-03.at.10.01.39.mp4
Related issues
n/a
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: