Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(cleanup): Remove show_apple_in_cab feature gate #6302

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

finnian0826
Copy link
Contributor

Description

Title

Test plan

CI

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • N/A

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.01%. Comparing base (144241a) to head (235e926).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6302      +/-   ##
==========================================
- Coverage   89.01%   89.01%   -0.01%     
==========================================
  Files         739      739              
  Lines       31604    31598       -6     
  Branches     5571     5876     +305     
==========================================
- Hits        28132    28126       -6     
+ Misses       3427     3274     -153     
- Partials       45      198     +153     
Files with missing lines Coverage Δ
src/keylessBackup/SignInWithEmail.tsx 98.09% <100.00%> (-0.09%) ⬇️
src/statsig/types.ts 100.00% <ø> (ø)

... and 66 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 144241a...235e926. Read the comment docs.

@finnian0826 finnian0826 marked this pull request as ready for review December 5, 2024 21:40
@finnian0826 finnian0826 added this pull request to the merge queue Dec 6, 2024
@finnian0826 finnian0826 removed this pull request from the merge queue due to a manual request Dec 6, 2024
@finnian0826 finnian0826 added this pull request to the merge queue Dec 6, 2024
Merged via the queue into main with commit b15cb12 Dec 6, 2024
15 checks passed
@finnian0826 finnian0826 deleted the finnian0826/act-1443-3 branch December 6, 2024 19:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants