Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(cleanup): Remove show_cash_in_token_filters feature gate #6343

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

finnian0826
Copy link
Contributor

@finnian0826 finnian0826 commented Dec 9, 2024

Description

Confirmed with product that we should remove

Test plan

CI

Related issues

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • N/A

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.95%. Comparing base (4c5db02) to head (cb8118a).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6343      +/-   ##
==========================================
- Coverage   88.95%   88.95%   -0.01%     
==========================================
  Files         737      737              
  Lines       31445    31437       -8     
  Branches     5833     5829       -4     
==========================================
- Hits        27973    27965       -8     
  Misses       3274     3274              
  Partials      198      198              
Files with missing lines Coverage Δ
.../fiatExchanges/FiatExchangeCurrencyBottomSheet.tsx 93.44% <100.00%> (-0.21%) ⬇️
src/statsig/types.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c5db02...cb8118a. Read the comment docs.

@finnian0826 finnian0826 marked this pull request as ready for review December 9, 2024 19:57
@finnian0826 finnian0826 enabled auto-merge December 9, 2024 20:12
@finnian0826 finnian0826 added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit ff027e2 Dec 9, 2024
15 checks passed
@finnian0826 finnian0826 deleted the finnian0826/act-1443-8 branch December 9, 2024 20:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants