Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove redundant translation line #6397

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

sviderock
Copy link
Contributor

Description

Remore redundant unused translation line.

Test plan

No testing needed.

Related issues

N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@sviderock sviderock enabled auto-merge January 6, 2025 09:25
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.08%. Comparing base (9815138) to head (fcab456).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #6397   +/-   ##
=======================================
  Coverage   89.08%   89.08%           
=======================================
  Files         736      736           
  Lines       31813    31813           
  Branches     6020     6023    +3     
=======================================
  Hits        28340    28340           
  Misses       3278     3278           
  Partials      195      195           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9815138...fcab456. Read the comment docs.

@sviderock sviderock added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@sviderock sviderock added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@sviderock sviderock added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@sviderock sviderock added this pull request to the merge queue Jan 7, 2025
Merged via the queue into main with commit e72427d Jan 7, 2025
16 checks passed
@sviderock sviderock deleted the slava/chore-redundant-translation branch January 7, 2025 09:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants