chore: update colors of transaction feed and points history icons #6450
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6450 +/- ##
========================================
Coverage 89.05% 89.05%
========================================
Files 730 730
Lines 31895 31890 -5
Branches 5792 6107 +315
========================================
- Hits 28405 28401 -4
+ Misses 3443 3292 -151
- Partials 47 197 +150
... and 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| @@ -186,7 +186,7 @@ exports[`SendConfirmation renders correctly 1`] = ` | |||
| "justifyContent": "center", | |||
| }, | |||
| { | |||
| "backgroundColor": "hsl(0, 53%, 93%)", | |||
| "backgroundColor": "#F8F9F9", | |||
There was a problem hiding this comment.
This file was removed with the new Review screen changes so this will probably become unnecessary after merging the main in
There was a problem hiding this comment.
oh yeah sorry, i didn't realise there were conflicts! should have resolved them before i nagged for reviews 🙈
yes correct - the reasoning is to keep the icons more muted and consistent, since the network icons are colorful already and this would draw more attention to them |
Description
This is planned for the transaction feed work but it also affects beefy, so I thought I'd just do it now. Kayla confirmed she is confident that she wants to go through with these changes (they're also in the demo designs) - rationale being taking away some color will bring more emphasis to the network icons.
Test plan
Related issues
Backwards compatibility
Y
Network scalability
If a new NetworkId and/or Network are added in the future, the changes in this PR will: