Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: remove default props #6461

Merged
merged 11 commits into from
Jan 31, 2025
Merged

chore: remove default props #6461

merged 11 commits into from
Jan 31, 2025

Conversation

MuckT
Copy link
Collaborator

@MuckT MuckT commented Jan 30, 2025

Description

Removes instances of defaultProps as this is slated to be removed from React in a future version: facebook/react#29233. Components, where a default prop was provided, had their associated props set to optional.

Test plan

  • Tested in CI.
  • Sanity Check on iOS and Android.

Related issues

N/A

Backwards compatibility

Yes

Network scalability

N/A

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 6 lines in your changes missing coverage. Please review.

Project coverage is 89.09%. Comparing base (bfef6e8) to head (6417658).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/components/KeyboardSpacer.tsx 44.44% 5 Missing ⚠️
src/navigator/Headers.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #6461    +/-   ##
========================================
  Coverage   89.09%   89.09%            
========================================
  Files         730      730            
  Lines       31827    31840    +13     
  Branches     5771     6121   +350     
========================================
+ Hits        28355    28367    +12     
+ Misses       3426     3278   -148     
- Partials       46      195   +149     
Files with missing lines Coverage Δ
src/components/BackButton.tsx 100.00% <100.00%> (ø)
src/components/CircleButton.tsx 100.00% <100.00%> (ø)
src/components/CurrencyDisplay.tsx 66.94% <100.00%> (-0.28%) ⬇️
src/icons/BackChevron.tsx 100.00% <100.00%> (ø)
src/icons/Backspace.tsx 100.00% <100.00%> (ø)
src/icons/BankIcon.tsx 100.00% <100.00%> (ø)
src/icons/Checkmark.tsx 100.00% <100.00%> (ø)
src/icons/ClockIcon.tsx 100.00% <100.00%> (ø)
src/icons/Envelope.tsx 100.00% <100.00%> (ø)
src/icons/Error.tsx 100.00% <100.00%> (ø)
... and 11 more

... and 63 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfef6e8...6417658. Read the comment docs.

@MuckT MuckT marked this pull request as ready for review January 30, 2025 23:43
Copy link
Collaborator

@kathaypacific kathaypacific left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@MuckT MuckT added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 290023c Jan 31, 2025
17 checks passed
@MuckT MuckT deleted the tomm/remove-default-props branch January 31, 2025 17:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants