Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: wrong translation used on SendConfirmation #6481

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

sviderock
Copy link
Contributor

Description

Wrong translation was used on the SendConfirmation screen.

Test plan

Related issues

N/A

Backwards compatibility

Yes

Network scalability

If a new NetworkId and/or Network are added in the future, the changes in this PR will:

  • Continue to work without code changes, OR trigger a compilation error (guaranteeing we find it when a new network is added)

@sviderock sviderock enabled auto-merge February 5, 2025 10:06
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (411b209) to head (1c37ccf).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6481      +/-   ##
==========================================
- Coverage   89.02%   89.02%   -0.01%     
==========================================
  Files         729      729              
  Lines       31871    31871              
  Branches     5819     6141     +322     
==========================================
- Hits        28374    28372       -2     
+ Misses       3449     3301     -148     
- Partials       48      198     +150     
Files with missing lines Coverage Δ
src/send/SendConfirmation.tsx 94.44% <ø> (ø)

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 411b209...1c37ccf. Read the comment docs.

@sviderock sviderock added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@sviderock sviderock added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 965edb9 Feb 5, 2025
16 checks passed
@sviderock sviderock deleted the slava/fix-missing-translation branch February 5, 2025 11:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants