chore(e2e): cleanup #6503
chore(e2e): cleanup #6503
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6503 +/- ##
==========================================
- Coverage 89.09% 89.08% -0.02%
==========================================
Files 732 732
Lines 31942 31942
Branches 6151 5833 -318
==========================================
- Hits 28459 28455 -4
- Misses 3285 3439 +154
+ Partials 198 48 -150 see 68 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
| * @param stableToken: recognised token symbol (e.g. 'cUSD') | ||
| * @param amountEther: amount in "ethers" (as opposed to wei) | ||
| */ | ||
| const fundWallet = async (senderPrivateKey, recipientAddress, stableToken, amountEther) => { |
There was a problem hiding this comment.
Guess this might be useful as a util if we have a test in the future that needs to use a new wallet with funds, but I guess we can refactor this later too
| return s | ||
| } | ||
|
|
||
| export async function waitForElementByText({ text, index, tap = false, timeout = 30_000 }) { |
There was a problem hiding this comment.
seems like there are a couple of usages for this. Are we removing since we favor test by ids over text?
There was a problem hiding this comment.
Detox's built-in element(by.text('...')) is robust enough that keeping this function doesn't make sense. By removing it now, we'll prevent its usage from growing.
Description
pixelmatche2e/src/utils/utils.jstoe2e/src/utils/navigation.jsTest plan
Related issues
Backwards compatibility
Yes
Network scalability
N/A