Fix policy #231
Merged
Fix policy #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialized value is already `0`.
To ELI5 this change when combined with 870dd88, assume the following example: 1. prediction sme request is sent, succeeds, and a bet is placed. 2. claude fails 3. prediction sme fails 4. prediction sme request is sent, succeeds, and a bet is placed. What we have: 1. counts: 0, 0, reward rates: 0, 0 2. counts: 0, 1, reward rates: 0, -0.01 3. counts: 1, 1, reward rates: -0.01, -0.01 4. counts: 1, 1, reward rates: -0.01, -0.01 What we should have, and the commit introduces: 1. counts: 1, 0, reward rates: 0, 0 2. counts: 1, 1, reward rates: 0, -0.01 3. counts: 2, 1, reward rates: -0,005, -0.01 4. counts: 3, 1, reward rates: -0,003333333, -0.01
We set a small punishment when the price has not been set or a nevermined subscription is used to avoid repeatedly using the same tool.
Adamantios
commented
Feb 27, 2024
There was a problem hiding this comment.
Unrelated change, but useful as it prevents reusing the same tool when using subscriptions.
Adamantios
commented
Feb 27, 2024
There was a problem hiding this comment.
Unrelated change, but this assignment was unnecessary.
dvilelaf
approved these changes
Feb 27, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To explain this PR, assume the following example:
What we have:
What we should have, and this PR introduces: