Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Incosistent Snowflake Defaults #403

Closed
LumaC0 opened this issue May 2, 2024 · 0 comments · Fixed by #491
Closed

Incosistent Snowflake Defaults #403

LumaC0 opened this issue May 2, 2024 · 0 comments · Fixed by #491
Labels
bug Something isn't working

Comments

@LumaC0
Copy link

LumaC0 commented May 2, 2024

Describe the bug
The source code in VannaBase.connect_to_snowflake checks default values with a structure like my-password while all 40 Snowflake notebooks use a default value like mypassword.

~/dev/notebooks :: main
➜ ag mypassword snowflake* | wc -l
40

~/dev/notebooks :: main
➜ ag my-password snowflake* | wc -l
0

The values can either be changed 40 times across notebooks or once in the base source.

Desktop (please complete the following information where):

  • OS: Arch Linux
  • Version: [e.g. 20.04]
  • Python: 3.10.8
@LumaC0 LumaC0 added the bug Something isn't working label May 2, 2024
supercoder-dev pushed a commit to supercoder-dev/vanna that referenced this issue Jun 9, 2024
@zainhoda zainhoda linked a pull request Jul 25, 2024 that will close this issue
zainhoda added a commit that referenced this issue Jul 25, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant