added milvus vectorstore support #448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng model in advance
|
I just needed this, thank you for your contribution!🥰 |
zainhoda
approved these changes
May 20, 2024
Closed
|
thanks for the contribution! |
|
Hi @yushangfu , thanks for your contribution. |
|
@zc277584121 Hi, Could you please ask @zainhoda to help you review your code? Currently I moved to another project, I have no Milvus env to test your code. Sorry for that |
|
@zc277584121 feel free to open a new PR from your branch |
|
Closing in favor of #496 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added milvus vectorstore support, but need to deploy milvus and embedding model in advance.
I tested it in my env, and everything is ok, please check, thanks