Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade Async Kit to 1.20.0 #621

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

PWrzesinski
Copy link
Contributor

Currently Fluent SQLite driver silently depends on features (specifically the shutdownAsync function) introduced in Async Kit 1.20.0. That dependency is transient, without specifying Async Kit in the SQLite driver's Package.swift, causing a compilation error when an earlier version (like 1.19.0) is used.

It would probably be more correct to specifically add that dependency in the SQLite driver's Package.swift, but personally I don't see anything wrong with just updating it here.

@PWrzesinski PWrzesinski requested a review from gwynne as a code owner November 18, 2024 12:40
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.43%. Comparing base (614d3ec) to head (dca918a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #621      +/-   ##
==========================================
- Coverage   24.78%   24.43%   -0.35%     
==========================================
  Files         149      149              
  Lines        8660     9353     +693     
==========================================
+ Hits         2146     2285     +139     
- Misses       6514     7068     +554     

see 81 files with indirect coverage changes

Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks!

@gwynne gwynne added the no-release-needed Doesn't require a release label Nov 18, 2024
@gwynne gwynne merged commit 2cceea2 into vapor:main Nov 18, 2024
15 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
no-release-needed Doesn't require a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants