Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix hard crash when describing "zero" datetime #64

Merged
merged 10 commits into from
Sep 8, 2021

Conversation

gwynne
Copy link
Member

@gwynne gwynne commented Sep 8, 2021

Fixes #63.

Also fixes a minor thread-safety issue and clears up deprecation warnings from NIOSSL.

@gwynne gwynne added the semver-patch Internal changes only label Sep 8, 2021
@gwynne gwynne requested review from Joannis, 0xTim and jdmcd September 8, 2021 09:51
@gwynne gwynne self-assigned this Sep 8, 2021
@gwynne gwynne force-pushed the fix-63-hard-crash-with-zero-time-data branch from 5571010 to 5b97bbe Compare September 8, 2021 10:23
Joannis
Joannis previously approved these changes Sep 8, 2021
0xTim
0xTim previously approved these changes Sep 8, 2021
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should really think about adding a linter to remove force unwraps across Vapor in the future

Copy link
Member

@jdmcd jdmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwynne gwynne merged commit e453cf5 into main Sep 8, 2021
@gwynne gwynne deleted the fix-63-hard-crash-with-zero-time-data branch September 8, 2021 14:11
@VaporBot
Copy link

VaporBot commented Sep 8, 2021

These changes are now available in 1.3.3

@gwynne
Copy link
Member Author

gwynne commented Sep 8, 2021

Note - CI failures are a MySQL bug, not a driver issue

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
semver-patch Internal changes only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hard crash from MySQLData with malformed data
5 participants