This repository has been archived by the owner on Sep 3, 2020. It is now read-only.
Avoid crashes on malformed RSA keys #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebkleveter
approved these changes
Apr 22, 2019
|
Hey @vzsg, you just merged a pull request, have a coin! You now have 2062 coins. |
|
And this is why importing |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #87.
The OpenSSL C APIs can return null pointers if
PEM_read_bio_PUBKEYand co. fail to parse the provided input. Only the certificate parsing code path was properly guarded, which lead to fatal errors.