Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Draft: Removals for v2 #445

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Draft: Removals for v2 #445

wants to merge 21 commits into from

Conversation

fabianfett
Copy link
Collaborator

This is a quick and dirty draft of the removals that we want to do for v2. Happy to split this into smaller prs (see commits).

@fabianfett fabianfett added semver-major Breaks existing public API. breaking To fix this bug or implement this feature we must break API labels Dec 13, 2023
@fabianfett fabianfett added this to the 2.0.0 milestone Dec 13, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2023

Codecov Report

Attention: Patch coverage is 59.81308% with 43 lines in your changes missing coverage. Please review.

Project coverage is 71.92%. Comparing base (d6b6487) to head (7937b2f).

Files with missing lines Patch % Lines
Sources/PostgresNIO/PostgresQueryMetadata.swift 63.33% 11 Missing ⚠️
Sources/PostgresNIO/New/PostgresError.swift 65.00% 7 Missing ⚠️
Sources/PostgresNIO/Pool/PostgresClient.swift 0.00% 7 Missing ⚠️
...es/PostgresNIO/Connection/PostgresConnection.swift 45.45% 6 Missing ⚠️
...w/Connection State Machine/CloseStateMachine.swift 0.00% 3 Missing ⚠️
...nection State Machine/ConnectionStateMachine.swift 70.00% 3 Missing ⚠️
...urces/PostgresNIO/New/PostgresChannelHandler.swift 78.57% 3 Missing ⚠️
...ion State Machine/AuthenticationStateMachine.swift 66.66% 1 Missing ⚠️
Sources/PostgresNIO/New/NotificationListener.swift 0.00% 1 Missing ⚠️
...tgresNIO/Utilities/SASLAuthenticationManager.swift 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #445       +/-   ##
===========================================
+ Coverage   61.75%   71.92%   +10.17%     
===========================================
  Files         125       75       -50     
  Lines       10089     8473     -1616     
===========================================
- Hits         6230     6094      -136     
+ Misses       3859     2379     -1480     
Files with missing lines Coverage Δ
.../Connection/PostgresConnection+Configuration.swift 51.35% <ø> (ø)
Sources/PostgresNIO/Data/PostgresDataType.swift 54.92% <ø> (-0.26%) ⬇️
Sources/PostgresNIO/Data/PostgresNumeric.swift 77.90% <ø> (ø)
Sources/PostgresNIO/Data/PostgresRow.swift 70.27% <ø> (+21.82%) ⬆️
...tion State Machine/ExtendedQueryStateMachine.swift 79.51% <100.00%> (ø)
... State Machine/PreparedStatementStateMachine.swift 91.83% <100.00%> (ø)
Sources/PostgresNIO/New/PSQLEventsHandler.swift 75.00% <ø> (ø)
Sources/PostgresNIO/New/PSQLTask.swift 77.77% <100.00%> (ø)
Sources/PostgresNIO/New/PostgresQuery.swift 69.67% <ø> (+0.35%) ⬆️
Sources/PostgresNIO/Utilities/NIOUtils.swift 0.00% <ø> (ø)
... and 11 more

... and 3 files with indirect coverage changes

# Conflicts:
#	Sources/PostgresNIO/Data/PostgresDataType.swift
#	Sources/PostgresNIO/Docs.docc/index.md
#	Sources/PostgresNIO/Message/PostgresMessage+Identifier.swift
#	Sources/PostgresNIO/New/PostgresChannelHandler.swift
#	Sources/PostgresNIO/Utilities/Exports.swift
#	Sources/PostgresNIO/Utilities/PostgresError+Code.swift
#	Tests/IntegrationTests/PostgresNIOTests.swift
#	Tests/PostgresNIOTests/New/Extensions/ConnectionAction+TestUtils.swift
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
breaking To fix this bug or implement this feature we must break API semver-major Breaks existing public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants