Embed sqlite amalgamation 3.48.0 source code and fix Sendable warnings #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
=======================================
Coverage 66.28% 66.28%
=======================================
Files 9 9
Lines 777 777
=======================================
Hits 515 515
Misses 262 262
|
ptoffy
reviewed
Jan 16, 2025
| @@ -103,7 +103,7 @@ extension SQLiteDatabase { | |||
| } | |||
|
|
|||
| /// Async version of ``withConnection(_:)-48y34``. | |||
| public func withConnection<T>( | |||
| public func withConnection<T: Sendable>( | |||
There was a problem hiding this comment.
No not in the way we care about. It will produce a warning unless you're in Swift 6 language mode and for now we're not considering that breaking (same with NIO apparently)
| @@ -162,7 +162,7 @@ private struct SQLiteDatabaseCustomLogger<D: SQLiteDatabase>: SQLiteDatabase { | |||
| self.database.withConnection(closure) | |||
| } | |||
| // See `SQLiteDatabase.withConnection(_:)`. | |||
| func withConnection<T>(_ closure: @escaping @Sendable (SQLiteConnection) async throws -> T) async throws -> T { | |||
| func withConnection<T: Sendable>(_ closure: @escaping @Sendable (SQLiteConnection) async throws -> T) async throws -> T { | |||
0xTim
approved these changes
Jan 16, 2025
| @@ -103,7 +103,7 @@ extension SQLiteDatabase { | |||
| } | |||
|
|
|||
| /// Async version of ``withConnection(_:)-48y34``. | |||
| public func withConnection<T>( | |||
| public func withConnection<T: Sendable>( | |||
There was a problem hiding this comment.
No not in the way we care about. It will produce a warning unless you're in Swift 6 language mode and for now we're not considering that breaking (same with NIO apparently)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 1.11.0
Full change list:
Sendablewarnings